Specify both YARP 3.4 and 3.5 style options for depthimage portmonitor #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoferigo
approved these changes
Apr 23, 2021
|
Some CI jobs are still failing, but this is due to #693 that hopefully should be fixed by robotology/icub-basic-demos#33 . |
Nicogene
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See robotology/yarp#2552 . As we now need to support both YARP 3.4 (Stable branches and latest releases) and YARP 3.5 (Unstable branches) we will pass both options, as this should work fine and avoid to trigger the bug robotology/yarp#2556 .
Fix #695